[libcxx-commits] [PATCH] D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 20 16:32:57 PST 2022


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Would it be better to instead `XFAIL` it using Lit machinery? Right now you're disabling the test even when it would succeed, which means you're losing that coverage.

I'm fine with the patch, but I think you may want to do something less drastic to retain coverage on your platform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140183/new/

https://reviews.llvm.org/D140183



More information about the libcxx-commits mailing list