[libcxx-commits] [PATCH] D135325: [CMake] cmake cache for hexagon libc++{, abi} + libunwind

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/cmake/caches/hexagon-linux-cxx17.cmake:2-3
+
+set(LIBCXX_TEST_PARAMS "std=c++17" CACHE STRING "")
+set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")
+set(LIBCXX_HAS_GCC_S_LIB OFF CACHE BOOL "")
----------------
Same here, it's a bit unusual to hardcode this in these caches. We only do it for the `Generic-XXXXX` caches since those are basically only used for the CI. I think it would make more sense to leave this unspecified by this cache.


================
Comment at: libcxx/cmake/caches/hexagon-linux-cxx17.cmake:4
+set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "")
+set(LIBCXX_HAS_GCC_S_LIB OFF CACHE BOOL "")
+
----------------
Are we mis-detecting this? If so, it would be best to fix it instead of hardcoding the value in this cache.


================
Comment at: libcxx/cmake/caches/hexagon-linux-cxx17.cmake:23
+
+set(UNIX ON CACHE BOOL "")
----------------
It's a bit unusual to encode something like this in these caches, since they should be about customizing libc++/libc++abi/libunwind specific knobs. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135325/new/

https://reviews.llvm.org/D135325