[libcxx-commits] [PATCH] D140424: [libc++] Also install libclang in the Docker image

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik created this revision.
philnik added a reviewer: Mordante.
Herald added a subscriber: arichardson.
Herald added a project: All.
philnik requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This is now everything that is required for clang-tidy checks.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D140424

Files:
  libcxx/utils/ci/Dockerfile


Index: libcxx/utils/ci/Dockerfile
===================================================================
--- libcxx/utils/ci/Dockerfile
+++ libcxx/utils/ci/Dockerfile
@@ -84,11 +84,12 @@
 RUN apt-get update && apt-get install -y clang-tidy-$(($LLVM_HEAD_VERSION - 1)) clang-tidy-$LLVM_HEAD_VERSION clang-tidy-14
 RUN ln -s /usr/bin/clang-tidy-14 /usr/bin/clang-tidy && [ -e $(readlink /usr/bin/clang-tidy) ]
 
-# Install llvm-dev to compile custom clang-tidy checks
-RUN apt-get update && apt-get install llvm-$(($LLVM_HEAD_VERSION - 1))-dev llvm-$(($LLVM_HEAD_VERSION - 2))-dev
+# Install llvm-dev and libclang-dev to compile custom clang-tidy checks
+RUN apt-get update && apt-get install -y llvm-$(($LLVM_HEAD_VERSION - 1))-dev     llvm-$(($LLVM_HEAD_VERSION - 2))-dev \
+                                     libclang-$(($LLVM_HEAD_VERSION - 1))-dev libclang-$(($LLVM_HEAD_VERSION - 2))-dev
 
 # TODO LLVM16 Don't install llvm-16-dev explicitly
-RUN apt-get update && apt-get install llvm-16-dev
+RUN apt-get update && apt-get install -y llvm-16-dev libclang-16-dev
 
 # Install clang-tools
 RUN apt-get update && apt-get install -y clang-tools-$(($LLVM_HEAD_VERSION - 1)) clang-tools-$LLVM_HEAD_VERSION


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D140424.484336.patch
Type: text/x-patch
Size: 1204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221220/d9af3039/attachment.bin>