[libcxx-commits] [PATCH] D140277: [libc++] Implement constexpr {isfinite, isinf, isnan, isnormal}

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM modulo some nits.



================
Comment at: libcxx/docs/Status/Cxx2b.rst:43
    .. [#note-P2273] P2273: ``make_unique_for_overwrite`` isn't done yet since `P1020` hasn't been implemented yet.
+   .. [#note-P0533R9] P0533R9: ``isfinite``, ``isinf``, ``isnan`` and ``isnormal`` are implemented
 
----------------
I really like this, this makes it easier to keep track regarding what is and what is not done. Thanks!


================
Comment at: libcxx/test/std/numerics/c.math/isfinite.pass.cpp:8
+//===----------------------------------------------------------------------===//
+
+#include <cassert>
----------------
Please add a synopsis, the same for the other tests.


================
Comment at: libcxx/test/std/numerics/c.math/isfinite.pass.cpp:19
+  static TEST_CONSTEXPR_CXX23 bool test() {
+    assert(std::isfinite(std::numeric_limits<T>::max()));
+    assert(!std::isfinite(std::numeric_limits<T>::infinity()));
----------------
Please test `min` and `denorm_min` too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140277/new/

https://reviews.llvm.org/D140277