[libcxx-commits] [PATCH] D122780: Modify std::sort: add BlockQuickSort partitioning algorithm for arithmetic types

[Nilay Vaish via Phabricator via libcxx-commits]

nilayvaish marked an inline comment as done.
nilayvaish added a comment.

@ldionne : this diff is ready for submission.  If you could do so, that would be great.



================
Comment at: libcxx/include/__algorithm/sort.h:326
+      do {
+        *__j = std::move(*__k);
+        __j = __k;
----------------
ldionne wrote:
> Your rebase is incorrect. You should be using `_Ops::__iter_move(__k)` instead of `std::move(*__k)` here and in a bunch of other places.
I have fixed all the places.  std::move is being only used to move the value, not the iterator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122780/new/

https://reviews.llvm.org/D122780