[libcxx-commits] [PATCH] D140313: libcxx: accept both GNU and ELF Tool Chain readelf format

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

Please make sure to have the repo set. Otherwise we don't get notifications on the patches.

LGTM assuming you checked locally that this actually fixes the problem.



================
Comment at: libcxx/utils/libcxx/sym_check/extract.py:184-185
+                    end = i + 1
+                if lines[i].startswith("Symbol table ("):
+                    end = i
         assert start != -1
----------------
emaste wrote:
> ELF Tool Chain readelf does not (currently) emit a blank line before the heading.
Could you add this as a comment in the code?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140313/new/

https://reviews.llvm.org/D140313