[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision

Michał Górny via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 19 08:56:45 PST 2022


mgorny added a comment.

In D139270#4005137 <https://reviews.llvm.org/D139270#4005137>, @ldionne wrote:

> Let's use `__tuple_dir` for LLVM 16 and rename it back to `__tuple` in LLVM 17. We also have the same problem for `__string` unless I am mistaken, @mgorny 
> can you handle that in your patch?

Will do.

> @mgorny Please let us know whether the above solution (i.e. rename but only for one release) works for you.

It's not perfect but it's good enough. I suppose you'll also accept future one-release renames if similar problems occur?

Also, I'd really prefer if you didn't call it "deficiency in the package manager" because I find that insulting to the lot of effort many of us put in the package managers. It's not a "deficiency", it's a conscious decision not to add a lot of complexity combined with fragility to handle a corner case affecting at most a few (libc++ is the only one I'm aware of) out of 20000+ packages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270



More information about the libcxx-commits mailing list