[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple_dir to avoid file collision

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D139270#4003752 <https://reviews.llvm.org/D139270#4003752>, @mgorny wrote:

>> That question can be turned around; why should software authors need to rename their source files to work around deficiencies in package managers?
>
> Well, I'm of the opinion that if you can help someone and it doesn't cost you anything, then there's no reason not to help. And that working with people who show concern about downstream problems and appreciation about their work is much nicer. The alternative is insulting distributors, so they lose interest, stop reporting bugs, start accumulating local patches and next thing you know, everything's one huge mess where every single program needs to include hacks for every variant of iibc++ out there.

+1 I think we should try to avoid breaking downstream.

I see the build failed, this has nothing to do with your patch. Can you rebase your patch on main to fix that issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270