[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D128084#4002429 <https://reviews.llvm.org/D128084#4002429>, @emaste wrote:

> With that addressed failure is now
>
>   + check-abi-list
>   + echo '+++ Running the libc++ ABI list test'
>   Running the libc++ ABI list test
>   + ninja -vC /usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b check-cxx-abilist
>   ninja: Entering directory `/usr/home/buildkite/.buildkite-agent/builds/freebsd-test-1/llvm-project/libcxx-ci/build/generic-cxx2b'
>   ninja: error: unknown target 'check-cxx-abilist'

I had a look and there are two issues

1. check-cxx-abilist requires and ABI list to be available. This can be generated with building the target `generate-cxx-abilist`. This should generate an abilist that should be included in libc++.
2. the target `generate-cxx-abilist` fails

  Traceback (most recent call last):
  
    File "/root/.buildkite-agent/builds/Lezard-Runner-2/llvm-project/libcxx-ci/libcxx/utils/generate_abi_list.py", line 40, in <module>
  
      main(sys.argv[1:])
  
    File "/root/.buildkite-agent/builds/Lezard-Runner-2/llvm-project/libcxx-ci/libcxx/utils/generate_abi_list.py", line 33, in main
  
      symbols = libcxx.sym_check.extract.extract_symbols(args.library)
  
    File "/root/.buildkite-agent/builds/Lezard-Runner-2/llvm-project/libcxx-ci/libcxx/utils/libcxx/sym_check/extract.py", line 294, in extract_symbols
  
      return extractor.extract(lib_file)
  
    File "/root/.buildkite-agent/builds/Lezard-Runner-2/llvm-project/libcxx-ci/libcxx/utils/libcxx/sym_check/extract.py", line 145, in extract
  
      dyn_syms = self.get_dynsym_table(out)
  
    File "/root/.buildkite-agent/builds/Lezard-Runner-2/llvm-project/libcxx-ci/libcxx/utils/libcxx/sym_check/extract.py", line 182, in get_dynsym_table
  
      assert start != -1

This needs modifications for FreeBSD in the file `utils/libcxx/sym_check/extract.py`. I think it makes sense to do that change in a separate review. Which modifications are required is outside my area of expertise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084