[libcxx-commits] [PATCH] D139235: Reapply "[libc++][ranges]Refactor `copy{, _backward}` and `move{, _backward}`"

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/valarray:4935
 #  include <concepts>
+#  include <cstring>
 #  include <functional>
----------------
var-const wrote:
> @ldionne I'm getting 
> ```
> $ "diff" "-w" "/llvm/libcxx/test/libcxx/transitive_includes/cxx2b.csv" "/llvm/build/generic-cxx2b/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv"
> # command output:
> *** /llvm/libcxx/test/libcxx/transitive_includes/cxx2b.csv
> --- /llvm/build/generic-cxx2b/test/libcxx/Output/transitive_includes.sh.cpp.dir/t.tmp/transitive_includes.csv
> ***************
> *** 722,728 ****
>   valarraycmath
>   valarraycstddef
>   valarraycstdlib
> - valarraycstring
>   valarrayinitializer_list
>   valarraylimits
>   valarraynew
> --- 722,727 ----
> 
> error: command failed with exit status: 1
> ```
> What's the reason this is only defined in C++20 and below?
We've decided to remove all transitive includes from C++2b, since it's not considered stable. You can just remove the `valarray cstring` line from `Cxx2b.csv`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139235/new/

https://reviews.llvm.org/D139235