[libcxx-commits] [PATCH] D128084: [libc++] Add CI job testing on FreeBSD

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D128084#3999869 <https://reviews.llvm.org/D128084#3999869>, @arichardson wrote:

> In D128084#3999857 <https://reviews.llvm.org/D128084#3999857>, @emaste wrote:
>
>> Quick status update, with D140117 <https://reviews.llvm.org/D140117> applied I still have the following failures:
>>
>>   Failed Tests (31):
>>     llvm-libc++-shared.cfg.in :: libcxx/atomics/bit-int.verify.cpp
>>     llvm-libc++-shared.cfg.in :: libcxx/experimental/fexperimental-library.compile.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/thread/futures/futures.task/futures.task.members/ctad.static.compile.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.cal/time.cal.month/time.cal.month.nonmembers/ostream.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.syn/formatter.day.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.syn/formatter.duration.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.syn/formatter.month.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.syn/formatter.weekday.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/time/time.syn/formatter.year.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/assign.U.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/assign.copy.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/assign.move.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/assign.unexpected.copy.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/assign.unexpected.move.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/assign/emplace.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/ctor/ctor.inplace_init_list.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/ctor/ctor.unexpect_init_list.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/dtor.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.expected/swap/free.swap.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/assign/assign.copy.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/assign/assign.move.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/assign/assign.unexpected.copy.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/assign/assign.unexpected.move.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/assign/emplace.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/ctor/ctor.unexpect_init_list.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/dtor.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/swap/free.swap.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/expected/expected.void/swap/member.swap.pass.cpp
>>     llvm-libc++-shared.cfg.in :: std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/ctad.static.compile.pass.cpp
>>
>> I'll iterate on adjusting XFAILs before submitting a final version of this change
>
> @emaste which compiler are you using? If it's /usr/bin/clang++ that is too old I believe and would explain those test failures.

Looking at the CI logs, clang 13 seems to be used, which is indeed too old. You have to upgrade to at least 14, 15 recommended for better test coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128084/new/

https://reviews.llvm.org/D128084