[libcxx-commits] [PATCH] D138795: [libc++] Don't assume that string_view::const_iterator is a raw pointer

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/formatter_output.h:260
+        _Iterator __last,
         output_iterator<const _CharT&> auto __out_it,
         __format_spec::__parsed_specifications<_ParserCharT> __specs,
----------------
ldionne wrote:
> Mordante wrote:
> > Wouldn't this work?
> Yes it would work, but don't you feel like it's more readable to introduce a separate name for the type?
My main concern it that by giving the type a name, it's intended to be configurable by the caller, which isn't intended.
Maybe lifting this requirement to a requires instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138795/new/

https://reviews.llvm.org/D138795