[libcxx-commits] [PATCH] D140022: [libc++][math.h] Remove __sun__ workarounds

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 14 06:56:02 PST 2022


ldionne added a comment.

Please see my latest comment in D138680 <https://reviews.llvm.org/D138680>. I don't want us to go halfway since that's just pushing the pain further down the road. We either support Solaris or we don't, and if we don't, I see no reason to remove some but not all the workarounds for that platform.

And if we do, then this patch can't ship as-is because it'll break Solaris, which we would then support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140022/new/

https://reviews.llvm.org/D140022



More information about the libcxx-commits mailing list