[libcxx-commits] [PATCH] D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

> The discussion about the meanings of these things should be taken to Discourse, not buried in a couple of patch reviews, in any case.

100% agree with you. I think we can straighten things out there, since this is well out of scope of this review.

The matter of fixing the definitions of these macros and long term refactoring aside, we plan to proceed with this patch if there are no objections as it's fixing a build break introduce by D137870 <https://reviews.llvm.org/D137870> which is still very much a present issue for us.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138864/new/

https://reviews.llvm.org/D138864