[libcxx-commits] [PATCH] D138951: Move several exception derived classes to c++abi library

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi added inline comments.


================
Comment at: libcxxabi/src/exceptions.cpp:25
+const char* bad_variant_access::what() const noexcept { return "bad_variant_access"; }
+} // namespace std
----------------
compnerd wrote:
> These really are not part of the ABI: https://itanium-cxx-abi.github.io/cxx-abi/abi.html.  This makes it harder to combine libc++ with an alternative ABI implementation (e.g. libsupc++ or libcxxrt).  Additionally, libc++ can be built with vcruntime and does not use libc++abi on Windows, so this will result in breaking the Window support.
Is vcruntime officially supported? It's not listed in https://releases.llvm.org/3.8.0/projects/libcxx/docs/BuildingLibcxx.html#abi-library-specific-options. 
Is the CI currently set it up use vcruntime on Windows and not relying on libcxxabi at all?

I will rely on @ldionne and @EricWF to help out since the original solution was shot down and they proposed to move those symbols to abi. I'm not sure if an alternative ABI implementations were considered or how to address the removal of symbols from libcxx and make them available in libcxxabi.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138951/new/

https://reviews.llvm.org/D138951