[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple2 to avoid file collision

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D139270#3989229 <https://reviews.llvm.org/D139270#3989229>, @Mordante wrote:

> In D139270#3989169 <https://reviews.llvm.org/D139270#3989169>, @tahonermann wrote:
>
>> I took a closer look at the files in the "__tuple" directory. None of them are directly included by the "tuple" header. They all appear to be related to support for tuple-like types in general; not to the implementation of `std::tuple`. That suggests names like "__tuple_protocol", "__tuple_support", or "__tuple_like" might be more appropriate. If @ldionne is supportive of any of those names (or something similar), I'll have no objection to a rename.
>
> Interesting. Normally we always should include the `__foo/*.h` headers in `foo`. But here we indeed don't do that. I leave the choice to @ldionne.

I'm quite certain this was an oversight. Almost all the headers are actually used in `<tuple>`. I wonder why the modules build doesn't complain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270