[libcxx-commits] [PATCH] D139421: [libcxx] <experimental/simd> implementation

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 12 09:08:46 PST 2022


Mordante added a comment.

In D139421#3977231 <https://reviews.llvm.org/D139421#3977231>, @Joy12138 wrote:

> @philnik @Mordante Hi reviewers! Thank you very much for your attention to this patch! There are exactly still many issues with this patch. In addition to the problems you mentioned, there are also problems with the logic of some tests. And there are still 4 tests that failed on arm64. And We have not run the test in Aarch64 and PPC environments. I believe that fixing these issues is necessary before the patch is merged.
>
> I will split the patch into multiple smaller patches and resubmit them later. And also check and fix all these issues in the process. This may take several weeks. I suggest you review the new patch set later. Of course, we are also glad if you have time to review this patch and give us more suggestions.

Thanks for the update. When possible, it would be great if you can upload one smaller patch when it's ready. Then we can review it and look whether the style matches libc++'s style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139421/new/

https://reviews.llvm.org/D139421



More information about the libcxx-commits mailing list