[libcxx-commits] [PATCH] D139189: [libc++] Granularize <type_traits> includes in <concepts>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

One request other than that LGTM.



================
Comment at: libcxx/test/libcxx/ranges/range.utility.helpers/different_from.compile.pass.cpp:18
+#include <__concepts/different_from.h>
+TEST_DIAGNOSTIC_POP
+
----------------
philnik wrote:
> jloser wrote:
> > Mordante wrote:
> > > What is the benefit of using a private header here?
> > I assume it's because there is no `std::different_from`, it's just a useful private concept that we have unit tests for.  I'm not sure this is the most appropriate home for these tests nested in `ranges/range.utility.helpers` as it's more generic than that (isomorphic to `std::same_as`).
> We check that `<__concpet/different_from.h>` is self-contained. We might as well, since we test implementation details anyways.
We typically don't do that, so IMO it would be good to add a comment like `Check that <__concpet/different_from.h> is self-contained.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139189/new/

https://reviews.llvm.org/D139189