[libcxx-commits] [PATCH] D138864: Setting the LLVM_TARGET_TRIPLE macro based on the LLVM_DEFAULT_TARGET_TRIPLE

[David Tenty via Phabricator via libcxx-commits]

daltenty added a comment.

In D138864#3956057 <https://reviews.llvm.org/D138864#3956057>, @phosek wrote:

> What's the issue you're trying to address? I just landed D137451 <https://reviews.llvm.org/D137451>, does it address your issue?

compiler-rt doesn't configure anymore for us on AIX, due to an empty variable expansion (which is derived from `LLVM_TARGET_TRIPLE`):

  $cmake -DLLVM_ENABLE_RUNTIMES=compiler-rt  ../llvm-project/runtimes
  ...
  CMake Error at ../llvm-project/compiler-rt/cmake/Modules/CompilerRTUtils.cmake:367 (string):
    string sub-command REPLACE requires at least four arguments.
  Call Stack (most recent call first):
    ../llvm-project/compiler-rt/CMakeLists.txt:120 (construct_compiler_rt_default_triple)

where the offending block is:

      set(COMPILER_RT_DEFAULT_TARGET_TRIPLE ${LLVM_TARGET_TRIPLE} CACHE STRING
            "Default triple for which compiler-rt runtimes will be built.")
  ...
    string(REPLACE "-" ";" LLVM_TARGET_TRIPLE_LIST ${COMPILER_RT_DEFAULT_TARGET_TRIPLE})


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138864/new/

https://reviews.llvm.org/D138864