[libcxx-commits] [PATCH] D139555: [libc++] Refactor char_traits

[Haowei Wu via Phabricator via libcxx-commits]

haowei added a comment.

We are seeing build breakages in Fuchsia's builders after this change was landed and this change is in the blamelist and looks directly related:

  [37031/289776](267) CXX kernel.efi_x64/obj/src/lib/llvm-profdata/libllvm-profdata.llvm-profdata.cc.o
  FAILED: kernel.efi_x64/obj/src/lib/llvm-profdata/libllvm-profdata.llvm-profdata.cc.o
  ../../../recipe_cleanup/clangehe1kz7e/bin/clang++ -MD -MF kernel.efi_x64/obj/src/lib/llvm-profdata/libllvm-profdata.llvm-profdata.cc.o.d -o kernel.efi_x64/obj/src/lib/llvm-profdata/libllvm-profdata...
  In file included from ../../src/lib/llvm-profdata/llvm-profdata.cc:5:
  In file included from ../../src/lib/llvm-profdata/include/lib/llvm-profdata/llvm-profdata.h:11:
  In file included from ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/string_view:220:
  ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/__string/char_traits.h:286:17: error: no member named '__constexpr_wmemcmp' in namespace 'std'; did you mean '__constexpr_memcmp'?
      return std::__constexpr_wmemcmp(__s1, __s2, __n);
             ~~~~~^
  ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/cstring:119:1: note: '__constexpr_memcmp' declared here
  __constexpr_memcmp(const _Tp* __lhs, const _Tp* __rhs, size_t __count) {
  ^
  In file included from ../../src/lib/llvm-profdata/llvm-profdata.cc:5:
  In file included from ../../src/lib/llvm-profdata/include/lib/llvm-profdata/llvm-profdata.h:11:
  In file included from ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/string_view:220:
  ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/__string/char_traits.h:290:17: error: no member named '__constexpr_wcslen' in namespace 'std'
      return std::__constexpr_wcslen(__s);
             ~~~~~^
  ../../../recipe_cleanup/clangehe1kz7e/include/c++/v1/__string/char_traits.h:297:17: error: no member named '__constexpr_wmemchr' in namespace 'std'
      return std::__constexpr_wmemchr(__s, __a, __n);
             ~~~~~^
  3 errors generated.
  clang++: error: failing because '-gen-reproducer' is used
  Fuchsia clang version 16.0.0 (https://llvm.googlesource.com/llvm-project fe9e442c57f3b50ec7ad5f01e191745aa3156b4e)
  Target: x86_64-unknown-windows-msvc
  Thread model: posix
  InstalledDir: ../../../recipe_cleanup/clangehe1kz7e/bin
  clang++: note: diagnostic msg:
  ********************
  
  PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
  Preprocessed source(s) and associated run script(s) are located at:
  clang++: note: diagnostic msg: clang-crashreports/llvm-profdata-960ad3.cpp
  clang++: note: diagnostic msg: clang-crashreports/llvm-profdata-960ad3.sh
  clang++: note: diagnostic msg:
  
  ********************

Could you take a look?
If it takes a while to fix, could you revert the change first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139555/new/

https://reviews.llvm.org/D139555