[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple2 to avoid file collision

[Tom Honermann via Phabricator via libcxx-commits]

tahonermann added a comment.

> Is __tuple2 acceptable to you if it's only for a single release?

I don't think so. Unless I'm misunderstanding something, the same issue would occur when trying to revert to the original `__tuple` name since there is still no guarantee that a `__tuple` file from an earlier version wasn't still present.

> That won't help with anything that uses DESTDIR/some staging area before merging to the live filesystem, unfortunately.

I'm not sure I'm following. It sounds like you are suggesting there are two issues:

1. As part of the install step performed by the LLVM build system, a `__tuple` file in the install location will interfere with the installation of the `__tuple` directory.
2. If the target of the install step performed by the LLVM build system is a staging area, then a secondary non-LLVM process that copies/merges (portions of) the LLVM install to a live system might (or might not) encounter a problem copying/merging the `__tuple` directory if a file is present.

If I have that right, then my perspective is that the second problem is not one that should be solved by LLVM. If I don't have that right, please clarify the scenario.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270