[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple2 to avoid file collision

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D139270#3984551 <https://reviews.llvm.org/D139270#3984551>, @tahonermann wrote:

> I've hit this issue too and it was a source of frustration. Though the directory name is an internal detail that we should be free to change, I don't like the name `__tuple2` as a permanent replacement. Unfortunately, any name we choose will be inconsistent with the names used for other such detail directories; the only directory currently present there that doesn't map directly to a header name is `__debug_utils`.

I ran into it in the past too, but as libc++ developer it's quite easy to figure out what happened. But I agree that for the average user the current way isn't user friendly.

> The core problem is that the install step does not attempt to delete any existing `__tuple` file before attempting to create the `__tuple` directory and copy files. Can we not just add a step to the install target to force that to happen?

I like this idea better than using (temporary) __fooN headers. @philnik do you know how easy it is to remove these "obsolete" files? This would solve upgrading, but not downgrading from the current `__foo` is a directory to `__foo` is a file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270