[libcxx-commits] [PATCH] D139273: [libc++] Move filter_view::iterator and sentinel out of filter_view

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D139273#3981777 <https://reviews.llvm.org/D139273#3981777>, @ldionne wrote:

> Can you add a comment to the commit message explaining why you're doing that. I remember we talked about it during a review at some point but leaving breadcrumbs would be nice.
>
> Also CC @var-const in case you want to do a few of them.

Sorry, I forgot to update the commit message. In case anybody finds this patch in the future, D138413#inline-1335968 <https://reviews.llvm.org/D138413#inline-1335968> contains the reason for this change. Basically, you can't easily specialize traits classes with dependent types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139273/new/

https://reviews.llvm.org/D139273