[libcxx-commits] [PATCH] D139493: [libc++abi] Optionally move __cxa_demangle into libc++demangle.a

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:135
+# separate static library for when it is actually needed.
+option(LIBCXXABI_STATIC_DEMANGLE_LIBRARY "Put __cxa_demangle into a separate static library" OFF)
+
----------------
I think that we should at least emit a warning when this option is enabled.  This makes libc++abi non-conforming as `__cxa_demangle` is part of the ABI definition as per https://itanium-cxx-abi.github.io/cxx-abi/abi.html.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139493/new/

https://reviews.llvm.org/D139493