[libcxx-commits] [PATCH] D138951: Move several exception derived classes to c++abi library

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxxabi/src/exceptions.cpp:25
+const char* bad_variant_access::what() const noexcept { return "bad_variant_access"; }
+} // namespace std
----------------
These really are not part of the ABI: https://itanium-cxx-abi.github.io/cxx-abi/abi.html.  This makes it harder to combine libc++ with an alternative ABI implementation (e.g. libsupc++ or libcxxrt).  Additionally, libc++ can be built with vcruntime and does not use libc++abi on Windows, so this will result in breaking the Window support.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138951/new/

https://reviews.llvm.org/D138951