[libcxx-commits] [PATCH] D139555: [libc++] Refactor char_traits

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/__string/char_traits.h:227
+        return nullptr;
+    return std::__constexpr_char_memchr(__s, __a, __n);
+  }
----------------
I would make this explicit, and I'd use `int` instead of `int_type` since `int` is what `memchr` takes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139555/new/

https://reviews.llvm.org/D139555