[libcxx-commits] [PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

Thu Dec 8 00:21:06 PST 2022

sepavloff added a comment.

LGTM.

In D139507#3980555 <https://reviews.llvm.org/D139507#3980555>, @qiucf wrote:

> In D139507#3978449 <https://reviews.llvm.org/D139507#3978449>, @sepavloff wrote:
>
>> Thank you for working on this!
>>
>> Is there any reason why we should keep the old intrinsic?
>
> In case any user outside of clang references it (although I believe no), we can deprecate it and remove after a few releases.

Yes, this could be a good solution.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139507/new/

https://reviews.llvm.org/D139507