[libcxx-commits] [PATCH] D138006: [libc++abi] Refactoring works around __dynamic_cast

[Adrian Vogelsgesang via Phabricator via libcxx-commits]

avogelsgesang added a comment.

Hi @Lancern,

Thanks for looking into the performance of `dynamic_cast` and for splitting your initial patch from https://reviews.llvm.org/D137315!
Unfortunately, it looks like your patch is still not rebased onto current main. E.g., your patch claims to delete a couple of lines which are not currently on https://github.com/llvm/llvm-project/blob/main/libcxxabi/src/private_typeinfo.cpp. I marked one of those examples below. That's also why the CI currently fails (see "patch application failed" link further up on this page). Let's get that sorted out first, and as soon as the diff is correct, I will start reviewing your changes (I see little value in reviewing a non-applicable patch)



================
Comment at: libcxxabi/src/private_typeinfo.cpp:667
-
-        if (src2dst_offset >= 0)
-        {
----------------
E.g., here: this line of code is not currently in https://github.com/llvm/llvm-project/blob/main/libcxxabi/src/private_typeinfo.cpp but your patch still tries to delete it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138006/new/

https://reviews.llvm.org/D138006