[libcxx-commits] [PATCH] D122780: Modify std::sort: add BlockQuickSort partitioning algorithm for arithmetic types

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 7 12:25:59 PST 2022


smeenai added a comment.

In D122780#3978947 <https://reviews.llvm.org/D122780#3978947>, @nilayvaish wrote:

> In D122780#3978826 <https://reviews.llvm.org/D122780#3978826>, @smeenai wrote:
>
>> I'm not able to apply the latest version of the patch, and it looks like CI isn't either. Which revision is this patch based on top of?
>>
>> Your stack still has D122858 <https://reviews.llvm.org/D122858> in it, which is making `arc patch` unhappy locally, but even taking the raw patch and using `git apply` is failing for me.
>
> @smeenai , can you try again?  I think I don't understand the 'arc' tool that well.

It's a pretty hard tool to understand, to be fair :)

I'm able to apply this now, thanks. I'm working on the size evaluation today; I should have that today if I don't run into any unexpected snags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122780/new/

https://reviews.llvm.org/D122780



More information about the libcxx-commits mailing list