[libcxx-commits] [PATCH] D139555: [libc++] Refactor char_traits

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In general I like the approach, some remarks. I really like to see the CI once it's running again.



================
Comment at: libcxx/include/__string/char_traits.h:362
     _LIBCPP_INLINE_VISIBILITY static constexpr
     const char_type* find(const char_type* __s, size_t __n, const char_type& __a) _NOEXCEPT;
 
----------------
Why is this function and length not changed? Do the builtins not work with them?


================
Comment at: libcxx/include/cstring:102
 
+inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR size_t __constexpr_strlen(const char* __str) {
+  return __builtin_strlen(__str);
----------------
Are these used except in the traits?
I really like to see some private tests for these functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139555/new/

https://reviews.llvm.org/D139555