[libcxx-commits] [PATCH] D139498: [libc++][Android] Android/Bionic headers don't work with modules

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

In D139498#3978802 <https://reviews.llvm.org/D139498#3978802>, @rprichard wrote:

> I'm definitely not ruling out adding Android/Bionic support for modules later on. They might be needed to fix things like the `user` namespace pollution in D139380 <https://reviews.llvm.org/D139380>. At the moment, the goal is to update the libc++ used on Android, which is a few years out of date.

I'm perfectly fine with getting things working again and polishing later. If it's intended to be fixed I rather see an
`XFAIL: LIBCXX-ANDROID-FIXME` to mark that it is an issue that should be fixed. We use, and have used, that for other platforms too. For example in this test `// XFAIL: LIBCXX-AIX-FIXME`, which is "defined" in `test/configs/ibm-libc++-shared.cfg.in`.

We tend to use `UNSUPPORTED` for things that are not supported and never will, for example we never expect Clang modules to work with GCC.

So I encourage you to implement a proper android XFAIL, but I don't see it as a blocker.

I have checked and I see AIX failures for other builds too, so I it seems an issue with the buildbots. (The same for your other patch.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139498/new/

https://reviews.llvm.org/D139498