[libcxx-commits] [PATCH] D139521: [libc++][NFC] Rename __libcpp_*_or_builtin to __constexpr_*

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Dec 7 08:56:16 PST 2022


Mordante added a comment.

Typically our internal functions like these are name `__libcpp_foo`, not `__libcpp_foo_or_builtin`. I see you now rename them to `__constexpr_foo`. Can you add comment to the commit message why you decided to use this new naming scheme?

I see the CI is red, but it just seems an internal test failure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139521/new/

https://reviews.llvm.org/D139521



More information about the libcxx-commits mailing list