[libcxx-commits] [PATCH] D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

Ok with me from the Windows perspective, as long as CI is passing. (Currently it seems to have failed for some unrelated reason?)



================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.temp_dir_path/temp_directory_path.pass.cpp:144
+        TEST_CHECK(win_dir_sz > 0 && win_dir_sz < MAX_PATH);
+        TEST_CHECK(win_dir[win_dir_sz-1] != L'\\');
+        TEST_CHECK(ret == win_dir);
----------------
I don't quite see why this specific line is needed here (I do kinda get what it hints at, based on the docs for `GetWindowsDirectoryW` though), but this should be effectively covered by the `ret == win_dir` check anyway, right? (I.e. the purpose of this test is to test the stdlib's temp path generation, not check `GetWindowsDirectoryW`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137131/new/

https://reviews.llvm.org/D137131