[libcxx-commits] [PATCH] D139502: [libc++][Android] Disable pbump2gig for Android

Ryan Prichard via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 6 20:28:11 PST 2022


rprichard created this revision.
rprichard added a reviewer: danalbert.
Herald added subscribers: danielkiss, pengfei.
Herald added a project: All.
rprichard requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Android devices frequently don't have enough memory to run this test.

e.g. On the API 33 x86-64 emulator with 2GiB RAM, the test triggers the
OOM Killer, the device reboots, and then `adb shell` exits with status
0 and no output.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D139502

Files:
  libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp


Index: libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp
===================================================================
--- libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp
+++ libcxx/test/std/input.output/stream.buffers/streambuf/streambuf.protected/streambuf.put.area/pbump2gig.pass.cpp
@@ -21,6 +21,11 @@
 // allocation failure when attempting to allocate the 2GiB string.
 // UNSUPPORTED: no-exceptions
 
+// Android devices frequently don't have enough memory to run this test. Rather
+// than throw std::bad_alloc, exhausting memory tends to trigger the OOM Killer
+// and/or crash the device (killing adb, rebooting it, etc).
+// UNSUPPORTED: android
+
 #include <sstream>
 #include <cassert>
 #include "test_macros.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139502.480761.patch
Type: text/x-patch
Size: 856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221207/04b533b7/attachment.bin>


More information about the libcxx-commits mailing list