[libcxx-commits] [PATCH] D139380: [libc++][Android] Rename user NS to User to avoid conflict with struct

Dan Albert via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 6 15:58:20 PST 2022


danalbert added a comment.

> Would you be able to report this as a bug to Android? Perhaps the struct can be removed when a macro is provided and they can start some sort of deprecation path?

We can add a macro, but I doubt we'll ever default to hiding this struct. Every time we've tried to make our headers more hygenic our users have told us they'd prefer it if we didn't because it breaks their builds (in trivially fixable ways, but they don't care; they don't want it to break regardless).

Our plan since then has been to ignore these types of problems until modules can solve them properly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139380/new/

https://reviews.llvm.org/D139380



More information about the libcxx-commits mailing list