[libcxx-commits] [PATCH] D134598: [libc++][format] Fixes Apple back deployment.

Tue Dec 6 10:09:03 PST 2022

Mordante created this revision.
Herald added subscribers: mstorsjo, arichardson.
Herald added a project: All.
Mordante updated this revision to Diff 462708.
Mordante added a comment.
Mordante updated this revision to Diff 462713.
Mordante updated this revision to Diff 462718.
Mordante updated this revision to Diff 462722.
Mordante updated this revision to Diff 463614.
Mordante updated this revision to Diff 463620.
Mordante updated this revision to Diff 463628.
Mordante updated this revision to Diff 463633.
Mordante updated this revision to Diff 463639.
Mordante updated this revision to Diff 479359.
Mordante updated this revision to Diff 479377.
Mordante updated this revision to Diff 479657.
Mordante updated this revision to Diff 479928.
Mordante updated this revision to Diff 479934.
Mordante updated this revision to Diff 479940.
Mordante updated this revision to Diff 480113.
Mordante updated this revision to Diff 480117.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Attempts to fix CI.

Mordante added a comment.

Attempts to fix CI.

Mordante added a comment.

Attempts to fix CI.

Mordante added a comment.

Attempt to fix CI.

Mordante added a comment.

Test CI.

Mordante added a comment.

CI testing.

Mordante added a comment.

CI test

Mordante added a comment.

More tests

Mordante added a comment.

CI test

Mordante added a comment.

Attempt to fix the CI.

Mordante added a comment.

CI fixes

Mordante added a comment.

CI fixes

Mordante added a comment.

Attempts to fix CI.

Mordante added a comment.

CI fixes.

Mordante added a comment.

Rebased, formatted, and reenable the entire CI.

Mordante added a comment.

CI fixes.

Mordante added a comment.

Fixes CI.

================
Comment at: libcxx/include/__chrono/formatter.h:52
+// platforms.
+#if _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT) &&                                              \
+    !defined(_LIBCPP_AVAILABILITY_DISABLE_FTM___cpp_lib_format)
----------------
This really looks like a compiler bug to me. Would you be able to get a smaller reproducer for the issue? We could get it fixed in Clang.

================
Comment at: libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp:15
+// This test requires the dylib support introduced in D92214.
+// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx1{{0|1}}.{{.+}}
+
----------------
I think that should work too, and IMO it's easier to read.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134598

Files:
  libcxx/include/__chrono/formatter.h
  libcxx/include/__chrono/ostream.h
  libcxx/include/__chrono/parser_std_format_spec.h
  libcxx/include/__format/concepts.h
  libcxx/include/__format/format_arg.h
  libcxx/include/__format/format_arg_store.h
  libcxx/include/__format/format_args.h
  libcxx/include/__format/format_context.h
  libcxx/include/__format/format_functions.h
  libcxx/include/__format/format_parse_context.h
  libcxx/include/__format/formatter_bool.h
  libcxx/include/__format/formatter_char.h
  libcxx/include/__format/formatter_floating_point.h
  libcxx/include/__format/formatter_integer.h
  libcxx/include/__format/formatter_integral.h
  libcxx/include/__format/formatter_output.h
  libcxx/include/__format/formatter_pointer.h
  libcxx/include/__format/formatter_string.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/chrono
  libcxx/test/libcxx/transitive_includes.sh.cpp
  libcxx/test/libcxx/utilities/format/format.arguments/format.arg/arg_t.compile.pass.cpp
  libcxx/test/libcxx/utilities/format/format.formatter/format.context/types.compile.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.day/time.cal.day.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.month/time.cal.month.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.cal/time.cal.year/time.cal.year.nonmembers/ostream.pass.cpp
  libcxx/test/std/time/time.duration/time.duration.nonmember/ostream.pass.cpp
  libcxx/test/std/time/time.syn/formatter.day.pass.cpp
  libcxx/test/std/time/time.syn/formatter.duration.pass.cpp
  libcxx/test/std/time/time.syn/formatter.month.pass.cpp
  libcxx/test/std/time/time.syn/formatter.weekday.pass.cpp
  libcxx/test/std/time/time.syn/formatter.year.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_format_args.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_format_args.sh.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg.store/make_wformat_args.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg/operator_bool.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.arg/visit_format_arg.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.args/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.args/get.pass.cpp
  libcxx/test/std/utilities/format/format.arguments/format.args/types.compile.pass.cpp
  libcxx/test/std/utilities/format/format.fmt.string/ctor.verify.cpp
  libcxx/test/std/utilities/format/format.fmt.string/get.pass.cpp
  libcxx/test/std/utilities/format/format.fmt.string/types.compile.pass.cpp
  libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.context/format.context/advance_to.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.context/format.context/arg.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.context/format.context/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.context/format.context/locale.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.context/format.context/out.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.bool.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.c_string.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char_array.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.const_char_array.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.floating_point.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.handle.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.pointer.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.signed_integral.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.string.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.unsigned_integral.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/begin.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.verify.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/ctor.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/end.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/types.compile.pass.cpp
  libcxx/test/std/utilities/format/format.functions/P2418.pass.cpp
  libcxx/test/std/utilities/format/format.functions/ascii.pass.cpp
  libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
  libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format.locale.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format_to.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format_to.locale.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format_to.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format_to.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format_to_n.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format_to_n.locale.verify.cpp
  libcxx/test/std/utilities/format/format.functions/format_to_n.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format_to_n.verify.cpp
  libcxx/test/std/utilities/format/format.functions/formatted_size.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/formatted_size.locale.verify.cpp
  libcxx/test/std/utilities/format/format.functions/formatted_size.pass.cpp
  libcxx/test/std/utilities/format/format.functions/formatted_size.verify.cpp
  libcxx/test/std/utilities/format/format.functions/locale-specific_form.pass.cpp
  libcxx/test/std/utilities/format/format.functions/unicode.pass.cpp
  libcxx/test/std/utilities/format/format.functions/vformat.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/vformat.pass.cpp
  libcxx/test/std/utilities/format/format.functions/vformat_to.locale.pass.cpp
  libcxx/test/std/utilities/format/format.functions/vformat_to.pass.cpp
  libcxx/utils/ci/run-buildbot

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134598.480117.patch
Type: text/x-patch
Size: 78228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221206/3f36ff9d/attachment-0001.bin>