[libcxx-commits] [PATCH] D139421: [libcxx] <experimental/simd> implementation

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

Thanks for working on this! It would be great to have a proper implementation of the parallelism TS. Unfortunately, the patch as-is is pretty much impossible to review because of the size. I've got a few high-level comments, but please split this up into smaller patches.



================
Comment at: libcxx/include/CMakeLists.txt:514
   __ranges/zip_view.h
+  __simd/vec_ext.h
+  __simd/config.h
----------------
These should be in `experimental/__simd`.


================
Comment at: libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp:147-152
+int main() {
+  test_all_simd_abi<CheckConcatSimd>();
+  test_all_simd_abi<CheckConcatSimdMask>();
+  test_all_simd_abi<CheckConcatResizeSimd>();
+  test_all_simd_abi<CheckConcatResizeSimdMask>();
+}
----------------
All the test `main()`s have to `return 0;` to support (semi-)freestanding environments.


================
Comment at: libcxx/test/std/experimental/simd/simd.casts/concat.pass.cpp:153
+}
\ No newline at end of file

----------------
Please make sure you have a newline at the end of the files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139421/new/

https://reviews.llvm.org/D139421