[libcxx-commits] [PATCH] D138680: [libc++] Remove Solaris related code

[Rainer Orth via Phabricator via libcxx-commits]

ro added a subscriber: jclulow.
ro added a comment.

As usual, it's complicated ;-)

- While I do run two Solaris buildbots (sparcv9 and amd64), those only include `llvm`, `clang`, and `compiler-rt`.
- The `libcxx` port isn't for Solaris only, but for Illumos (OpenSolaris derivative), too, so Solaris isn't the only stakeholder here.  In fact, IIRC, the Illumos port was done in a way to break the Solaris-specific code, not particularly friendly IMO.
- About two years ago, I tried myself at reviving the Solaris port while keeping the Illumos port working (although I believe it also had become broken at that point).  I got it working on both OSes, and the test results weren't too bad.  At that time, I even included support for Solaris 11.3, which, unlike 11.4, lacks XPG7 locale support.  However, the 11.3 part would be ripped out today since I'm about to obsolete everything before 11.4 in GCC 13.The differences between Solaris and Illumos were minor at that point: only one of the 14-part patch series I came up with was Illumos-specific.
- To test the waters, I sumitted the first patch in the series (D81602 <https://reviews.llvm.org/D81602>) to learn if the `libcxx` community would be amenable to reenabling the port.

However, as a prerequisite to move that patch (and the rest) forward, I learned that I would be required to setup Solaris instances of the `libcxx` CI.  Unfortunately, that subproject uses `buildkite`, yet another buildbot besides LLVM's `buildbot` (and Golang's `builder`), which isn't even ported to Solaris (and won't build last time I tried).  Add to that the fact that I'm already swamped with Solaris GCC, LLVM, and GDB maintenance and that my knowledge of C++ is minimal, I don't seem myself in the position to handle all that (getting the port integrated, setting up CI,...).

I can ask if someone inside Oracle is interested in taking up those tasks (I could host the CI, but nothing more).  Unless there's someone to handle this, I'd have to decline.

However, this is only part of the deal: even if the Solaris port per se would be unmaintained, there's still the Illumos community which might be interested in taking this up.  @jclulow might have suggestions here.

It would certainly good to have this port working, both for Solaris/Illumos and for `libcxx`: diversity usually helps pinpoint unwarranted assumptions in the codebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138680/new/

https://reviews.llvm.org/D138680