[libcxx-commits] [PATCH] D122780: Modify std::sort: add BlockQuickSort partitioning algorithm for arithmetic types

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 5 11:41:04 PST 2022


ldionne added inline comments.


================
Comment at: libcxx/include/__algorithm/sort.h:326
+      do {
+        *__j = std::move(*__k);
+        __j = __k;
----------------
Your rebase is incorrect. You should be using `_Ops::__iter_move(__k)` instead of `std::move(*__k)` here and in a bunch of other places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122780/new/

https://reviews.llvm.org/D122780



More information about the libcxx-commits mailing list