[libcxx-commits] [PATCH] D138680: [libc++] Remove Solaris related code

Mon Dec 5 10:02:28 PST 2022

theraven added a subscriber: voskresensky.vladimir.
theraven added a comment.

In D138680#3971179 <https://reviews.llvm.org/D138680#3971179>, @theraven wrote:

> tBricks was using this, but I think they've migrated off Solaris now.  I'll check.  I haven't had a Solaris system for a very long time.

They've confirmed that they are no longer using it.  They were using it with libcxxrt, not libc++abi, so I have no idea if libc++abi ever worked with Solaris.

I am happy for it to be removed if no one steps up to maintain it.  The various OpenSolaris derivatives' libc implementations have diverged enough that they're almost certainly not using this.

I believe @voskresensky.vladimir may have some idea whether Oracle is interested in maintaining any of this but if not then removing support seems the right path.

It looks as if Solaris added POSIX2008 locale support at some point in the last 12 years and so if anyone *is* interested in having it officially supported, then most of these hacks can be removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138680/new/

https://reviews.llvm.org/D138680