[libcxx-commits] [PATCH] D139231: [libc++] Move the definition of aligned allocation helpers outside of <new>

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__memory/aligned_alloc.h:10
+#ifndef _LIBCPP___MEMORY_ALIGNED_ALLOC_H
+#define _LIBCPP___MEMORY_ALIGNED_ALLOC_H
+
----------------
Why is the header not included by `__memory`? When intended it would be good to document why it's the case.
Then the guarded include in the `.cpp` files can be removed too.


================
Comment at: libcxx/include/__memory/aligned_alloc.h:19
+#endif
+
+_LIBCPP_BEGIN_NAMESPACE_STD
----------------
Shouldn't this code be guarded by `_LIBCPP_HAS_NO_LIBRARY_ALIGNED_ALLOCATION`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139231/new/

https://reviews.llvm.org/D139231