[libcxx-commits] [PATCH] D139270: [libc++] Rename __tuple to __tuple2 to avoid file collision

Michał Górny via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Dec 4 11:10:15 PST 2022


mgorny added a comment.

I've regenerated files. However, I needed to modify the generator to strip the extra `2` from public header name. That's not the prettiest solution, I admit, so I'm open to better ideas.



================
Comment at: libcxx/include/CMakeLists.txt:516
   __std_stream
   __string/char_traits.h
   __string/extern_template_lists.h
----------------
Mordante wrote:
> IIRC this used to be a file to, is that also an issue?
Yeah, it was. However, since it's in 15.x already, I don't have a strong opinion wrt fixing it now. It only occurred to me now that there's a relatively simple solution to the problem.

If you think we should change that too, then I can make a patch (perhaps separate from this one?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139270/new/

https://reviews.llvm.org/D139270



More information about the libcxx-commits mailing list