[libcxx-commits] [PATCH] D136775: [libc++][format] Adds formatter for tuple and pair

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/format/format.tuple/pair.pass.cpp:34
+struct settings {
+  std::optional<std::basic_string_view<CharT>> separator{};
+  std::optional<std::pair<std::basic_string_view<CharT>, std::basic_string_view<CharT>>> brackets{};
----------------
vitaut wrote:
> nit: {} is redundant
I removed it, but it turns out not to be redundant. When omitted GCC will issue a diagnostic. I then recalled that was why I added it before, so added a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136775/new/

https://reviews.llvm.org/D136775