[libcxx-commits] [PATCH] D137476: [libc++] Add utilites for instantiating functions with multiple types

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/support/test_iterators.h:1307
+using bidirectional_iterator_list =
+    concatenate_t<random_access_iterator_list<Ptr>, type_list<bidirectional_iterator<Ptr>>>;
+
----------------
var-const wrote:
> Question: why does `bidirectional_iterator_list` include random access iterators? From the name, I would expect it to be _at most_ bidirectional.
I mean it the other way around, as-in "everything that is a bidirectional_iterator", like we need for the algorithm tests - bidirectional and everything better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137476/new/

https://reviews.llvm.org/D137476