[libcxx-commits] [PATCH] D138461: [libcxxabi] Always use thread_local for cxa_exception_storage

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D138461#3954545 <https://reviews.llvm.org/D138461#3954545>, @smeenai wrote:

> Thanks for the revert.
>
> We could take an intermediate approach where we detect `thread_local` support via CMake and turn on `HAS_THREAD_LOCAL` in that case, instead of removing the non-`thread_local` code path entirely. That'd let us shake out any issues with the `thread_local` path while also preserving support for other platforms (though I'm surprised we're still supporting platforms which have threads but not `thread_local`).

Yes, I'd support that approach. Let's call the macro `_LIBCXXABI_HAS_THREAD_LOCAL`, though. I'll commit to figuring out what's wrong on the platforms I saw that didn't support thread_local.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138461/new/

https://reviews.llvm.org/D138461