[libcxx-commits] [PATCH] D137739: [libc++] Implement P0339R6 (polymorphic_allocator<> as a vocabulary type)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with green CI and comments applied. Thanks @LRFLEW for the comments, those were good observations.



================
Comment at: libcxx/include/__memory_resource/polymorphic_allocator.h:113
+
+#  endif
+
----------------



================
Comment at: libcxx/test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/allocate_bytes.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
Let's name this `allocate_deallocate_bytes.pass.cpp`. Same for `allocate_object.pass.cpp`.


================
Comment at: libcxx/test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/allocate_bytes.pass.cpp:61
+  test<std::byte>();
+  test<S>();
+}
----------------
`return 0;`

Everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137739/new/

https://reviews.llvm.org/D137739