[libcxx-commits] [PATCH] D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors

Thu Dec 1 08:56:57 PST 2022

ldionne accepted this revision.
ldionne added subscribers: joanahalili, hans, alexfh.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM with green CI. However, since we had some debug symbols regressions in previous `vector` patches, I would like to get a sense of whether this one might be a problem.

Pinging @dblaikie @hans @alexfh @joanahalili. Can one of you help us figure out whether that's going to be a problem for you folks? I think you had a semi-easy way of checking this. Also, I think it would be useful to get tests for this kind of stuff inside libc++ itself so we don't have to do this manually every time. We can't afford rebuilding all of Chromium on every patch, but perhaps if you can work with us to reproduce a smaller test that would be representative of what you see, we could start from that?

@philnik Let's ship this on next Monday unless we have an update regarding the code size. Thanks for fixing this.

Also, can you please make sure to file a bug report against libc++ regarding the pre-existing issue about exception rollback.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138601/new/

https://reviews.llvm.org/D138601