[libcxx-commits] [PATCH] D138629: [libc++][math.h] Add double overloads

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Thanks a lot @aaron.ballman and @Izaron for the additional context around builtins and builtin headers, this has been useful.

So this patch is effectively a no-op as far as we're concerned in a world with compiler builtins. However, it would make libc++ work when used in the following combination:

1. on top of a C library that does not provide these math functions, and
2. `-fno-builtins` is passed to the compiler

I think we want to do this, however I am having a hard time just LGTMing it because we are not currently validating anything wrt this patch. Can you please rebase to at least get a green CI run?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138629/new/

https://reviews.llvm.org/D138629