[libcxx-commits] [PATCH] D122780: Modify std::sort: add BlockQuickSort partitioning algorithm for arithmetic types

Thu Dec 1 07:09:01 PST 2022

nilayvaish added a subscriber: ayzhao.
nilayvaish added a comment.

In D122780#3955522 <https://reviews.llvm.org/D122780#3955522>, @ldionne wrote:

> In D122780#3955083 <https://reviews.llvm.org/D122780#3955083>, @nilayvaish wrote:
>
>> @ldionne : thanks for the accepting the change.  We are trying to evaluate the effect of the change on Android APK's size.  You might recall there were several comments about increased APK size in https://reviews.llvm.org/D113413 after it was submitted.  I think it would be better if we are aware of the change in APK's size beforehand.
>>
>> The evaluation is taking time, hopefully would get done soon.
>
> Thanks for the update. We'll be eager to hear about the results if you are allowed to share them. Hopefully there is no prohibitive code size regression. If so, it may be worth investigating if externally instantiating some of these templates in the dylib could mitigate the regression. IIRC this optimization was only enabled for integer types, right?

@ayzhao reported that this change would increase Chrome Android APK size by about 65.54 KB.  The Chrome team is OK with this for now.  For comparison, when we shifted to introsort, the increase was about 120 KB.

The optimization would be enabled for all arithmetic types.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122780/new/

https://reviews.llvm.org/D122780