[libcxx-commits] [PATCH] D137640: [libcxx] Implement P2467R1: Support exclusive mode for fstreams

[Twice via Phabricator via libcxx-commits]

PragmaTwice added inline comments.


================
Comment at: libcxx/test/std/input.output/file.streams/fstreams/fstream.cons/noreplace.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
ldionne wrote:
> This should be inside `fstream.cons/path.pass.cpp` instead.
> 
> And we're missing tests for the other places where this flag can now be used, like `basic_filebuf`, `basic_ofstream`, etc. Those tests should be added to their existing tests for constructors that take `openmode`.
Hi @ldionne, thanks for your review.

I notice that there is a comment `UNSUPPORTED: c++03, c++11, c++14` in `path.pass.cpp`, but it seems we need `UNSUPPORTED: c++03, c++11, c++14, c++17, c++20` for noreplace. Hence I wonder if a new test file is more suitable here?

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137640/new/

https://reviews.llvm.org/D137640